onepub-dev / onepub-dev/dcli

windows unit test leave the path polluted

Open
#146 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Dart
Stars
265
Forks
30
PR merge metrics
No merged PRs in 30d

Description

When running windows unit test we are permanently adding the test paths to the PATH registry setting.

We need to change the test so the don't write to the registry or if they do they restore the registry after each setting.

We really need the path change to be local otherwise unit tests will run against the wrong dcli install.

We should look to see if we can get the unit tests to use a singular copy of pub-cache rather than each test having its own copy.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Windows unit tests and the code that changes the PATH registry setting. Verify that test runs leave the registry unchanged and do not select the wrong dcli installation; investigate whether the tests can share one pub-cache copy.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart
Domain
cli, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.