onepub-dev / onepub-dev/dcli

Make progress active

Open
#110 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Dart
Stars
265
Forks
30
PR merge metrics
No merged PRs in 30d

Description

For commands that use progress the command should be inactive until the function is called. The progress then calls the command and streams the results.

We can then remove the progress argument from commands

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the commands that currently use a progress argument and the progress implementation that should invoke them. Trace how command execution and result streaming currently work. Done means progress can call an inactive command and the progress argument is removed from the affected commands without breaking their output.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart
Domain
cli
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.