onecrayon / onecrayon/api.ashes.live

Enhancement: add support for "optional" dice flags

Open
#127 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
13
Forks
7
Avg merge
7h 39m
Merged PRs (30d)
1

Description

The idea here is that for cards like Temple Elder or Glory Aspirant, the card should show up when doing a search for only basics, but ALSO show up when searching for the dice type that their abilities trigger off. To do this, we need a third dice flags column that is ignored by the basics search, but still checked for the other colors.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by tracing the card search entry point and the existing dice-flags storage and filtering, then identify where a third optional-flags column belongs. Done means basics-only searches ignore that column while searches for other colors also match cards through it.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.