oneapi-src / oneapi-src/unified-runtime
Resolve L0 warnings on Windows
@szadam is already working on this.
Since Nov 6, 2023.
- Dominant language
- C++
- Stars
- 57
- Forks
- 120
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 1
Description
The L0 adapter build currently suppresses a set of Windows warnings here, mostly related to conversion between different types:
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-levels-3-and-4-c4244?view=msvc-170
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4267?view=msvc-170
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4805?view=msvc-170
We are also suppressing warnings about insecure use of getenv:
D:\a\unified-runtime\unified-runtime\source\ur\ur.cpp(17,28): warning C4996: 'getenv': This function or variable may be unsafe. Consider using _dupenv_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\a\unified-runtime\unified-runtime\build\source\adapters\level_zero\ur_adapter_level_zero.vcxproj]
Here's an example log from a failed build with these warnings: https://github.com/pbalcer/unified-runtime/actions/runs/6404367037/job/17384798148
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.