oneapi-src / oneapi-src/unified-runtime

Consider whether `urQueueCreateWithNativeHandle` requires taking a device

Open
#778 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
57
Forks
120
Avg merge
1d 14h
Merged PRs (30d)
1

Description

"do we need then the device argument in urQueueCreateWithNativeHandle? I think the reason why make_queue passes nullptr for device is that the native queue has been created already in a given device, so it's not like you can create the new queue with the native handle in another device."

from: https://github.com/intel/llvm/pull/10491#issuecomment-1644844777

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the urQueueCreateWithNativeHandle API and the make_queue call referenced in PR #10491. Trace how the native queue's device is represented, then decide whether the device argument is necessary; done means a documented API decision and consistent handling of that argument.

Written by the indexing model from the issue text.

Assessment

Domain
api
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.