oneapi-src / oneapi-src/unified-runtime
Add extra size error case in CTS for USM alloc tests
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 57
- Forks
- 120
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 1
Description
I've added a TODO in the CTS for urUSMDevice/Shared/HostAlloc InvalidUSMSize tests for producing a UR_RESULT_ERROR_INVALID_USM_SIZE error. The condition of size is greater than UR_DEVICE_INFO_MAX_MEM_ALLOC_SIZE is currently uncovered:
Looks like it's caused a bunch of fails, probably due to known issues with implementing
UR_DEVICE_INFO_MAX_MEM_ALLOC_SIZE. I think we might just need to omit testing the upper limit on this one and let the return code be a "possible" one rather than mandatory.
Originally posted by @aarongreig in https://github.com/oneapi-src/unified-runtime/pull/2642#discussion_r1941549657
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the CTS for urUSMDevice/Shared/HostAlloc InvalidUSMSize tests and inspect the existing TODO and nearby invalid-size cases. Confirm how the test handles sizes above UR_DEVICE_INFO_MAX_MEM_ALLOC_SIZE, then update coverage and verify the expected UR_RESULT_ERROR_INVALID_USM_SIZE behavior, including whether the upper-limit result should be optional.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100