oneapi-src / oneapi-src/unified-runtime
Add variants of `UUR_KNOWN_FAILURE_ON` to perform xfail and/or negative device matching
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 57
- Forks
- 120
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 1
Description
Currently UUR_KNOWN_FAILURE_ON accepts a list of device specifiers and skips the tests if any match. It would be nice to extend this logic to:
- Mark the test as xfail (if such a thing exists in gtest), so that developers writing a patch would be notified of tests that they need to re-enable. Note that converting
UUR_KNOWN_FAILURE_ONdirectly to use xfails will not work, as some tests segfault which would bring the whole test suite down. - Use a negative match; "this test fails on every device except the ones matched by this specifier". Will be useful for testing features that are currently in development and do not work on every device yet.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the implementation and call sites for UUR_KNOWN_FAILURE_ON, then check whether the project's gtest setup supports xfail-like behavior without allowing segfaults to terminate the suite. Define how positive and negative device matching should be expressed, and verify that known failures are reported while tests remain safely skipped where necessary.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100