oneapi-src / oneapi-src/unified-runtime
Look into and reconsider CTS tests with high fail rate across adapters.
Open
@RossBrunton is already working on this.
Since Jan 7, 2025.
conformance
- Dominant language
- C++
- Stars
- 57
- Forks
- 120
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 1
Description
We've got a few CTS tests that only pass on one or two adapters. The behaviour these tests are enforcing isn't being missed upstream in the backends that are failing, which I think is a sign that either: these tests should have some skipping mechanism, we need a spec adjustment, or in the cases where only one adapter passes we could consider making them adapter specific tests.
These are the ones I noticed while working on the device parameterization PR:
- urEventSetCallbackTest.ValidateParameters has a match entry for every adapter (although the opencl one may be config specific) (https://github.com/oneapi-src/unified-runtime/pull/2527 and maybe look into other adapters)
- urEventGetProfilingInfo.Success - UR_PROFILING_INFO_COMMAND_COMPLETE fails on all adapters apart from CL, maybe just needs to be optional (https://github.com/oneapi-src/unified-runtime/pull/2533 )
- urProgramSetSpecializationConstants InvalidValueSize, InvalidValueId and InvalidValuePtr have match entries for all adapters apart form CL - likely there's a missing skip for these one because cuda and hip don't support the entry point at all (https://github.com/oneapi-src/unified-runtime/pull/2539 )
- urUSM*Alloc InvalidUSMSize tests all fail for cuda, hip and native cpu - might simply not be possible to check this on these backends ( https://github.com/oneapi-src/unified-runtime/pull/2557 )
- urDeviceGetGlobalTimestampTest SuccessSynchronizedTime fails on every adapter, only passes on CL CPU ( https://github.com/oneapi-src/unified-runtime/pull/2547 )
- urEnqueueKernelLaunchKernelSubGroupTest fails on every adapter but CL
- urEnqueueKernelLaunchTest.InvalidKernelArgs fails on every adapter but CL ( https://github.com/oneapi-src/unified-runtime/pull/2564 )
- urMemBufferCreateWithNativeHandleTest has a lot of match entries, all native handle entry points should be optional so almost certainly just missing a skip
( https://github.com/oneapi-src/unified-runtime/pull/2562 )
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.