oneapi-src / oneapi-src/unified-runtime
Inconsistent comment about the use of copy engine
Open
Nobody has claimed this yet.
level-zero
- Dominant language
- C++
- Stars
- 57
- Forks
- 120
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 1
Description
The implementation says "main copy engine"
https://github.com/oneapi-src/unified-runtime/blob/02ffa90480d42a1a0393e40f1e019b74fa50c6a2/source/adapters/level_zero/device.cpp#L1089
but the above comment says "no copy engines"
// If the environment variable is not set, no copy engines are used when
// immediate commandlists are being used. For standard commandlists all are
// used.
Please clarify.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open source/adapters/level_zero/device.cpp around line 1089 and compare the "main copy engine" wording with the preceding comment about "no copy engines." Clarify the comments so their description of copy-engine use is consistent, then review the surrounding code to ensure the wording matches the behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100