oneapi-src / oneapi-src/unified-runtime

urQueueCreateWithNativeHandle shouldn't allow hDevice to be null

Open
#2,041 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
57
Forks
120
Avg merge
1d 14h
Merged PRs (30d)
1

Description

Associating a ur_queue_handle_t with a ur_context_handle_t is sort of meaningless if we are using a multi device context, as the context doesn't tell us which device in the context the queue should be associated with. As such I think we should not allow the hDevice param to be null.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the urQueueCreateWithNativeHandle declaration and its implementations, then inspect how null hDevice values are currently handled. Done means a null hDevice is rejected consistently for this API, with tests covering the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.