oneapi-src / oneapi-src/unified-runtime
Memory pooling issue in HIP adapter
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 57
- Forks
- 120
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 1
Description
HIP adapter has an ifdef to enable pooling support in urUSMPoolCreate: https://github.com/oneapi-src/unified-runtime/blob/4aeb55e87192474830a9c762409c964560f51ea3/source/adapters/hip/usm.cpp#L388 The define, however is never set which means we do not test HIP with pooling enabled at all.
I tried setting UMF_ENABLE_POOL_TRACKING but this results in segfault in tests:
# ./bin/test-sum
...
[----------] 12 tests from urUSMHostAllocTest
[ RUN ] urUSMHostAllocTest.Success/AMD_HIP_BACKEND___AMD_Radeon_RX_6800_XT___UsePoolEnabled
Segmentation fault (core dumped)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in source/adapters/hip/usm.cpp around line 388 and reproduce the issue with the UsePoolEnabled case in bin/test-sum. Investigate why enabling UMF_ENABLE_POOL_TRACKING causes the reported segmentation fault. Done means HIP pooling is exercised by the tests without crashing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100