oneapi-src / oneapi-src/unified-runtime
CL adapter improvement: enable USM hints
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 57
- Forks
- 120
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 1
Description
We have big commented out blocks in our implementations of USMAdvise and USMPrefetch https://github.com/oneapi-src/unified-runtime/blob/93902794c09f1c8cb5163089f0eacfe55c1f1b86/source/adapters/opencl/usm.cpp#L377 suggesting that the CL equivalents to these functions aren't yet widely supported. I had a go at uncommenting one of these and fixing the mild bitrot that's set in, and at the very least I didn't get an error when I tested it (on gen 12 igpu driver). We should look at removing the comments if support has indeed been rolled out to a decent extent.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in source/adapters/opencl/usm.cpp around the commented implementations of USMAdvise and USMPrefetch. Check the corresponding OpenCL support and validate the change on the referenced Gen 12 integrated-GPU driver. Done means the supported implementation no longer relies on the commented-out blocks and works without an error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- infrastructure
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 43/100