oneapi-src / oneapi-src/unified-runtime
Define Command Buffers in core UR
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 57
- Forks
- 120
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 1
Description
A design suggestion was made in a comment in the the Native CPU command_buffer.cpp file in https://github.com/oneapi-src/unified-runtime/commit/27bbfcf105f2aaa832ba35ac9c08c7852bb77c6b by @uwedolinsky
Stub implementations of UR experimental feature command-buffers
Taken almost unchanged from another adapter. Perhaps going forward
these stubs could be defined in core UR as the default which would
reduce code duplication. Adapters could then "override" these defaults.
Requested by @EwanC in https://github.com/oneapi-src/unified-runtime/pull/1059#discussion_r1389253830 to open this up as an issue for discussion so it doesn't get lost. I have made an additional comment in the file to link to this issue while it is discussed.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Native CPU command_buffer.cpp comment and commit 27bbfcf105f2aaa832ba35ac9c08c7852bb77c6b, then inspect how the experimental command-buffer stubs are represented in core UR and adapters. Review the discussion in pull request #1059 to establish the intended default and override behavior. Done means the design is agreed and the core/adapters change is implemented consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100