oneapi-src / oneapi-src/unified-runtime
Fix CUDA adapter-level tracing
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 57
- Forks
- 120
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 1
Description
Most of the tracing implementation is ifdef'ed on XPTI_ENABLE_INSTRUMENTATION variable. This is never set in UR's build system (it is in SYCL PI).
Also, CUDA adapter cmake scripts never link with xpti.
I suggest using existing UR_ENABLE_TRACING variable instead. It already controls fetching in XPTI, so cmake changes will be simpler that way.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with adapters/source/adapters/cuda/tracing.cpp and inspect the CUDA adapter CMake scripts. Compare the XPTI_ENABLE_INSTRUMENTATION guards with UR_ENABLE_TRACING and review how tracing dependencies are fetched and linked. Done means CUDA adapter tracing uses the existing build variable and builds with the required XPTI linkage when tracing is enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system, observability
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100