oneapi-src / oneapi-src/unified-memory-framework

Add -Wsign-compare and -Wconversion flags

Open
#440 1 comment 0 reactions 1 assignee View on GitHub

@lplewa is already working on this.

Since Apr 17, 2024.

enhancement
Dominant language
C
Stars
98
Forks
48
Avg merge
3d 20h
Merged PRs (30d)
6

Description

On windows some of those problems are detected - what causes fully working on Linux PR to fail on Windows, what is annoying.
Unfortunately, those Flags are more restrictive then on windows (by adding those flags we have to fix ~40 warnings in the code)

Question: Do we want to include those compiler flags?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.