oneapi-src / oneapi-src/unified-memory-framework
Do we have some functionality in the tests disabled under Valgrind that still should be run under Valgrind?
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 98
- Forks
- 48
- Avg merge
- 3d 20h
- Merged PRs (30d)
- 6
Description
Do we have some functionality in the tests disabled under Valgrind that still should be run under Valgrind?
If so and we could split the test - we should split them.
Details
The tests disabled under Valgrind:
- in ./umf_test-memspace_host_all
- allocsSpreadAcrossAllNumaNodes of memspaceHostAllProviderTest
- in ./umf_test-provider_os_memory_config:
- providerConfigTest: protection_flag_none and protection_flag_read
- numa_modes/providerConfigTestNumaMode.
See https://github.com/oneapi-src/unified-memory-framework/pull/343 for more details.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the Valgrind-disabled cases in ./umf_test-memspace_host_all and ./umf_test-provider_os_memory_config, along with PR #343 for context. Determine whether allocsSpreadAcrossAllNumaNodes, the specified providerConfigTest cases, and numa_modes/providerConfigTestNumaMode can be split so the applicable functionality runs under Valgrind. Done means the relevant tests run under Valgrind without unnecessarily disabling unrelated cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100