oneapi-src / oneapi-src/unified-memory-framework

use C11 atomics and remove c++ code from utils_concurrency.h

Open
#1,234 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C
Stars
98
Forks
48
Avg merge
3d 20h
Merged PRs (30d)
6

Description

remove C++ code related to atomics from utils_concurrency.h and use C11 atomics instead

#else /* __cplusplus */
#include <atomic>
#define _Atomic(X) std::atomic<X>

// TODO remove cpp code from this file
using std::memory_order_acq_rel;
using std::memory_order_acquire;
using std::memory_order_relaxed;
using std::memory_order_release;

#endif /* __cplusplus */

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the conditional atomics section in utils_concurrency.h, including the existing C++ definitions and memory-order names. Confirm the file no longer contains the shown C++ atomics code and uses C11 atomics consistently, then run the repository's relevant tests if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.