oneapi-src / oneapi-src/unified-memory-framework
cleanup CMAKE lib vars
Open
Nobody has claimed this yet.
bug
- Dominant language
- C
- Stars
- 98
- Forks
- 48
- Avg merge
- 3d 20h
- Merged PRs (30d)
- 6
Description
Today we define set of lib-related CMAKE vars like:
-- Will fetch jemalloc from https://github.com/jemalloc/jemalloc.git (tag: 5.3.0)
-- JEMALLOC_LIBRARIES = /home/rrudnick/unified-memory-framework/build/_deps/jemalloc_targ-build/lib/libjemalloc.a
-- JEMALLOC_INCLUDE_DIRS = /home/rrudnick/unified-memory-framework/build/_deps/jemalloc_targ-build/include
-- JEMALLOC_LIBRARY_DIRS = /home/rrudnick/unified-memory-framework/build/_deps/jemalloc_targ-build/lib
the problem is that we mix *_LIBRARIES with *_LIBRARY_DIRS - we should have full path defined only in *_LIBRARY_DIRS.
Additionally, all vars defined in UMF should have an "UMF" prefix.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test path is specified. Start by locating the CMake definitions and references for the library-related variables, then inventory UMF-defined variables across the build configuration. Done means library paths use the *_LIBRARY_DIRS convention and UMF-defined variables consistently carry the UMF prefix without breaking the build.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, cmake
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100