oneapi-src / oneapi-src/unified-memory-framework

add valgrind instrumentation

Open
#1,120 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C
Stars
98
Forks
48
Avg merge
3d 20h
Merged PRs (30d)
6

Description

currently, our valgrind instrumentation is empty:

#define VALGRIND_DO_MEMPOOL_ALLOC(pool, ptr, size)                             \
    do {                                                                       \
        (void)(pool);                                                          \
        (void)(ptr);                                                           \
        (void)(size);                                                          \
    } while (0)

#define VALGRIND_DO_MEMPOOL_FREE(pool, ptr)                                    \
    do {                                                                       \
        (void)(pool);                                                          \
        (void)(ptr);                                                           \
    } while (0)
#endif

additionally, our GPU workflows should be run with all instrumentation enabled (could be done in Nightly builds)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the VALGRIND_DO_MEMPOOL_ALLOC and VALGRIND_DO_MEMPOOL_FREE macro definitions and identify the GPU workflow configuration. Start by checking how instrumentation is currently disabled, then verify that the macros perform the intended Valgrind mempool operations and that GPU workflows run with instrumentation enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
testing, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.