oneapi-src / oneapi-src/level-zero-tests
Failing tests are not failing gracefully
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 64
- Forks
- 69
- PR merge metrics
- No merged PRs in 30d
Description
Tests implicitly assume that every API call returns success.
E.g. Module handle passed to zeModuleCreate is not even initialized on app side, then if module creation fails then incorrect handle is passed to zeModuleDestroy which leads to segfault. Tests should check the error code and provide graceful teardown without crashes
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating tests that call zeModuleCreate and zeModuleDestroy, then inspect how their return codes and module handles are handled. Reproduce a failed module creation if possible and trace teardown. Done means failed API calls are checked and cleanup cannot pass an uninitialized or invalid handle to zeModuleDestroy, avoiding crashes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100