olucurious / olucurious/PyFCM

Timeout for OAuth2 Ignored in notify Method

Open
#361 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
814
Forks
209
PR merge metrics
No merged PRs in 30d

Description

When calling the notify method, there is an input parameter called timeout. While this timeout is applied correctly for the FCM URL, it's not being considered for the OAuth2 call, which defaults to 120 seconds regardless of the provided timeout value.

Can this be adjusted so that the timeout value applies to both the FCM URL and OAuth2 requests?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the notify method and trace how its timeout is applied to the FCM URL and OAuth2 request. Reproduce the issue with a timeout shorter than 120 seconds, then verify that both requests honor the provided value.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.