olucurious / olucurious/PyFCM

How should we send notifications to multiple tokens with the updated API?

Open
#338 16 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
814
Forks
209
PR merge metrics
No merged PRs in 30d

Description

Attempting to use async_notify_multiple_devices yields

Traceback (most recent call last):
   ...
   ...
  File "/usr/local/lib/python3.6/dist-packages/pyfcm/fcm.py", line 81, in async_notify_multiple_devices
    return self.send_async_request(payloads=payloads, timeout=timeout)
TypeError: send_async_request() got an unexpected keyword argument 'payloads'

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in fcm.py at async_notify_multiple_devices, noted at line 81, and compare its call with the send_async_request signature. Reproduce the multiple-token notification request and verify that the updated API path no longer raises the unexpected-keyword error.

Written by the indexing model from the issue text.

Assessment

Tech stack
firebase, python
Domain
api, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.