ollama / ollama/ollama-python

Could you add the `with-as` syntax

Open
#614 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
10.5k
Forks
1.2k
Avg merge
4m
Merged PRs (30d)
1

Description

It is better to add with-syntax

with ollama.Client() as c: pass
...
Traceback (most recent call last):
File "", line 1, in
TypeError: 'Client' object does not support the context manager protocol

My approach is (for MacOS)

    def __enter__(self, *args, **kwargs):
        import sh
        sh.brew.services.start.ollama()
        return self

    def __exit__(self, *args, **kwargs):
        import sh
        sh.brew.services.stop.ollama()

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the ollama.Client entry point and inspect how client resources are created and closed. Determine the intended context-manager lifecycle rather than assuming the MacOS-specific brew service behavior is appropriate. Done means the documented with ollama.Client() as c form works and its cleanup behavior is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
ollama, python
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.