Performance Enhancement Int to Int Comparison.
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 161
- Forks
- 68
- Avg merge
- 11d 17h
- Merged PRs (30d)
- 2
Description
STRATZ_Ken -
@Howard You should change
https://github.com/odota/parser/blob/master/src/main/java/opendota/Parse.java#L726
with @OnEntityCreated. When CDOTA_NPC_Observer_Ward is created, store the DtClass().getClassId() in a variable. Then you can compare on ProcessEntity with int == int comparison. I just did this on my side on a lot of things monitored, lowered CPU across the board by 8%.
Howard - Today at 6:06 PM
Thanks, could you log an issue?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/main/java/opendota/Parse.java around line 726 and read how @OnEntityCreated and ProcessEntity handle CDOTA_NPC_Observer_Ward. Trace the entity class ID flow, then verify that the comparison uses the stored integer value and run the parser's available checks to confirm behavior and performance are preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, performance
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100