odoo / odoo/runbot

Improve behaviour when adding / updating required CIs

Open
#1,508 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

mergebot
Dominant language
Python
Stars
159
Forks
156
Avg merge
1d 13h
Merged PRs (30d)
16

Description

Currently when changing the required CIs on the project the state of every PR (and staging?) gets recomputed which is very expensive and highly disruptive (plus it destroys historical information, the PR status is now pending even though the PR was successful at the time).

  • only open PRs and active stagings should be recomputed
  • if a PR has been approved, request the new CI if necessary

=> the dependency between status and project statuses should probably be removed and reimplemented by hand when modifying the project statuses.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace the project required-CI update path and the status recomputation logic for pull requests and stagings. Determine how project-status dependencies trigger recomputation, then verify that only open PRs and active stagings change, approved PRs request newly required CIs when needed, and historical statuses remain intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
ci-cd
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
40/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.