odoo / odoo/runbot

Better UX for external contributors being delegated to

Open
#1,041 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

mergebot
Dominant language
Python
Stars
159
Forks
156
Avg merge
1d 13h
Merged PRs (30d)
16

Description

This is likely a very low need, but jotting it down as I was thinking about this issue: for reasons of more reliable attribution and tracking, the reviewer of a PR needs their email correctly set[^1]. This means if a community member is delegated and tries to approve a PR the bot will reject the review (or something).

Currently this just results in a feedback message telling the user to contact an admin but that's not really helpful as it provides no clue as to who the admins are, how to contact them, and what to ask for.

In reality it would make sense for the 'bot to state that the administrators have been messaged, and to message_post on the PR targeting either the runbot administrators or the contact / partner managers so they can check if configuring the external user for this makes sense.

[^1]: the author doesn't because in most cases the commits are correctly tagged, the two cases where it's not are merges (rebase-merge and merge) and in that case the bot is attributed the authorship of the merge commit[^2]

[^2]: with the specific exception of the head of a PR being a merge commit, in which case we essentially rebase that merge commit, in theory this is useful when the merge commit needs to be non-trivial (e.g. conflict resolution) though AFAIK it's very much a secret and essentially never used, it's more common to just rebase the entire thing and resolve all conflicts

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the existing feedback message for delegated external contributors and the PR review handling described in the issue. Confirm how administrators or contact/partner managers are identified and how message_post is used; done means the bot tells the contributor that administrators were messaged and posts the relevant PR notification.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
developer-experience
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.