odoo / odoo/docker

[Feature Request] Improve security by using docker secret for password

Open
#302 8 comments 7 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Dockerfile
Stars
1.2k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

Please support "docker secrets" for passwords. Most major apps (and all databases) support this.

So instead of this:

version: "3.7"
services:

  postgresql:
    environment:
      POSTGRES_PASSWORD: foo
    # ...

  odoo:
    environment:
      PASSWORD: foo

We can do this:

version: "3.7"
services:

  postgresql:
    secrets:
      - postgresql_password
    environment:
      POSTGRES_PASSWORD_FILE: /run/secrets/odoo_postgresql_password     # supported
    # ...

  odoo:
    secrets:
      - postgresql_password
    environment:
      PASSWORD_FILE: /run/secrets/odoo_postgresql_password              # unsupported

  secrets:
    postgresql_password:
      file: odoo_postgresql_password

This is more secure. Most secure database deployments do it like this, so odoo is the weak link in the chain (as we need to put the password in plaintext).

Here are the docs.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Docker Compose secrets configuration reference linked in the issue and compare its PostgreSQL example with the Odoo service example. Trace how the Odoo container currently receives its password, then define the supported secret-file behavior and verify that passwords can be supplied without plaintext environment values.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker
Domain
infrastructure, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.