Interpolating unsafe elements into a document via JSX can change surrounding HTML structure
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 179
- Forks
- 63
- Avg merge
- 5h
- Merged PRs (30d)
- 22
Description
I'm currently using Unsafe.data to bring known-good HTML fragments (produced by a reasonable markdown->HTML generator) into the tyxml world. AIUI, that should be okay, but perhaps the current issue demonstrates that it is not.
When Unsafe.data-produced content that contains a self-closed tag (e.g. <div/>) is interpolated into a JSX template, the structure surrounding that interpolation is changed. For example, interpolating the poison element as shown here yields an HTML document where the div containing "2" is pulled into its predecessor, so that both "1" and "2" are surrounded by a red border:
let greet = () => {
let poison = Tyxml.Html.Unsafe.data("<div/>");
<html>
<head><title>"Home"</title></head>
<body>
<div style="border:solid red 1px">
"1" poison
</div>
<div> "2" </div>
</body>
</html>
}
A Dream playground example is available with this code already populated, demonstrating the problem: http://dream.as/XYZ68EQPDKVt
A quick side test of this using only tyxml (i.e. no jsx) yields the expected behaviour, so it seems the interpolation into jsx is the culprit somehow.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the example in the linked Dream playground, then compare the JSX interpolation path with the reported tyxml-only test using Tyxml.Html.Unsafe.data. Trace how a self-closed
fragment is handled during interpolation. Done means the surrounding HTML structure remains unchanged while the existing Unsafe.data behavior is preserved.Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100