jsx: Support optional props passing
Open
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 179
- Forks
- 63
- Avg merge
- 5h
- Merged PRs (30d)
- 22
Description
Given the following code:
open Tyxml;
module SearchBar = {
let createElement = (~query="", ()) => Html.txt(query)
};
};
let page = (~query=?, ()) => {
<SearchBar ?query />;
};
This error appears when running through tyxml-jsx :
Error: Unexpected optional jsx attribute query at ?query
rtop -dsource doesn't output anything
cc @Drup
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the example through tyxml-jsx and compare it with the rtop -dsource output mentioned in the report. Trace how JSX attributes are parsed and handled, then verify that the optional query prop no longer raises an error and that the example transforms successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100