Uses deprecated Longident.parse
Open
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 179
- Forks
- 63
- Avg merge
- 5h
- Merged PRs (30d)
- 22
Description
With OCaml 4.11 you get this deprecation warning when compiling tyxml. I believe this is causing a fatal build error.
46 | (Longident.parse @@ implementation i ^ "." ^ s)
^^^^^^^^^^^^^^^
Error (alert deprecated): Migrate_parsetree.Ast_405.Longident.parse
this function may misparse its input,
use "Parse.longident" or "Longident.unflatten"
Full build log is here:
https://kojipkgs.fedoraproject.org//work/tasks/3434/43633434/build.log
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the codebase for the Longident.parse call shown in the issue, then inspect the surrounding construction of the identifier. Build tyxml with OCaml 4.11 and verify that the deprecated alert and fatal build error no longer occur.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100