ocsigen / ocsigen/reactiveData
RList.make_from_s cannot be used within update step
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 52
- Forks
- 10
- Avg merge
- 4m
- Merged PRs (30d)
- 1
Description
make_from_s uses React.S.value, which can raise a Failure when executed within an update step. I haven't been able to define it using only React non-primitive operators. Even though coping out to a concurrency monad does work, it's not desirable here since it'd introduce a new dependency (and force the user's hand in deciding between Lwt/async/other).
Similarly, all the imperative operations on the handle are unsafe within an update step -- this should at least be documented.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/reactiveData.ml around make_from_s, especially the use of React.S.value, and review the linked React documentation about update steps. Inspect the handle's imperative operations for the same restriction. Done means either a safe React-based approach is established or the update-step limitation is clearly documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- api
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100