Add validation for datafile_maxsize parameter
Open
Nobody has claimed this yet.
dima
type: task
- Dominant language
- C++
- Stars
- 2.9k
- Forks
- 342
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 53
Description
Description
When modifying the datafile_maxsize configuration parameter, the system should validate whether sufficient disk capacity is available.
Current Behavior
- The
datafile_maxsizevalue should be a valid and meaningful value. - During adaptive expansion, when expanding beyond 1G, the expansion occurs in 1G increments.
- If the expansion reaches the configured
datafile_maxsizelimit, the final expansion will go up to that limit, and no further expansion is possible. - If the expansion hits the physical disk capacity limit before reaching the
datafile_maxsizelimit, it will still attempt to expand in 1G increments. If the remaining disk space is less than 1G, expansion stops. Unlike the behavior when hittingdatafile_maxsize, it does not expand up to the remaining disk capacity.
Proposed Solution
Add validation logic to check for sufficient disk space when the datafile_maxsize parameter is set or modified.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by locating the datafile_maxsize configuration handling and adaptive expansion entry point, then trace how disk capacity and 1G expansion increments are checked. Done means setting or modifying the parameter validates available capacity and expansion handles the remaining disk space consistently with the configured limit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- databases
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100