oceanbase / oceanbase/seekdb

Remove unused wait_event and stat_event definitions

Open
#433 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

dima type: task
Dominant language
C++
Stars
2.9k
Forks
342
Avg merge
1d 19h
Merged PRs (30d)
52

Description

Description

The files wait_event/ob_wait_event.h and statistic_event/ob_stat_event.h contain all the kernel's wait event and statistic event definitions. Many of these definitions are unused and should be identified and removed from the repository.

Unused definitions fall into two categories:

  1. Those that are not referenced anywhere in the code.
  2. Those where the macro parameter enable field is passed as false; these are effectively not compiled.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with wait_event/ob_wait_event.h and statistic_event/ob_stat_event.h, then search the repository for each definition and its enable parameter usage. Confirm which definitions have no references or are disabled with enable set to false. Done means removing only those unused definitions while preserving referenced events and keeping the project buildable.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
observability
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.