[Enhancement]: Build container image in GHA
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 2.9k
- Forks
- 342
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 53
Description
Hi, @SamYuan1990
Here's the dockerfile of seekdb, https://github.com/oceanbase/docker-images/tree/main/seekdb, it's in another repo, can you provide the process how you build the image in GHA, the error message seems like you use the start script in seekdb's image, if you see this error, it's because the config file of seekdb is not generated, can you also provide the log of seekdb, it's in /var/lib/oceanbase/log in the container.
Originally posted by @chris-sun-star in #36
and offline discussed with @longdafeng , I created this new issue for build container image in GHA for this Repo.
The current implementation in Docker involves downloading an RPM package
As an external party, I am unable to determine how you compiled this RPM. If there any modifications within this RPM, I(as user) am unaware of them.
From the perspective of continuous integration, an image should be built whenever a PR is merged, and even a simple test(as docker run?) should be run to ensure the quality.
Back to the current situation, the Dockerfile depends on an RPM package, which is not included in the continuous integration process.
This means that each RPM must be built first before the image can be built.
I don't think the main issue at the moment lies with the base image; Consider it's more of a release management problem, I create a new issue as enhancement before maintainer team accept it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the current Dockerfile, the RPM package dependency, and the repository's GitHub Actions configuration. Define the CI flow so the package and container image are built together after a PR merge, then run the proposed docker run smoke test and verify the seekdb logs under /var/lib/oceanbase/log.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, github-actions
- Domain
- build-system, ci-cd, devops
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100