oceanbase / oceanbase/seekdb

[Enhancement]: Check folder and files under this repo

Open
#34 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: enhancement
Dominant language
C++
Stars
2.9k
Forks
342
Avg merge
1d 19h
Merged PRs (30d)
52

Description

Enhancement

I hope maintainers can double check if folders and files under this repo are all belongs to CE(community edition) version, or well organized. Lesson learn from previous story, some one mis commit dependency as src, makes the repo hard to clone and checkout.

Today, I try to checkout this repo and it's too slow.

tree -L 1
.
├── CMakeLists.txt
├── CODE_OF_CONDUCT.md
├── CONTRIBUTING.md
├── LICENSE
├── NOTICE
├── README.md
├── README_CN.md
├── asan_ignore_list.txt
├── build.sh
├── cmake
├── deps
├── dockerfile
├── docs
├── images
├── mittest
├── package
├── profile
├── rpm
├── script
├── src
├── test
├── tools
└── unittest

I suggest we checking folder inside this repo and across repos under oceanbase org.

I am not sure if deps folder can be moved into a common repo, then for this repo, add the new repo into cmake lists.

  • Profile folder:
    I am curious on if those performance specific prof files effective for all CPU under same arch, or not? For example there are many arm CPUs...does this single file works for all?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the repository root listing from tree -L 1, then inspect CMakeLists.txt, deps, and profile; use the linked oceanbase code searches to compare dependency organization across repositories. Done would require a concrete decision on whether deps belongs in a common repository and whether the profile files apply across CPUs in the same architecture.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.