Operator callback in network layer doesn't make sense.
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- C++
- Stars
- 4.4k
- Forks
- 1.6k
- PR merge metrics
- No merged PRs in 30d
Description
很多sql 命令最后在网络回调operator 的执行, 这种方式 模块化不是很清晰, 另外, 对性能冲击很大, 一个很小的回车就要刷一次网络rpc.
网络层不应该做这么复杂的操作, 网络层本身是非常容易出问题的地方, 应该设计越简单越好
更优雅是在session layer 或者sql 层去调operator 的执行, 并且申请一块内存, 重复使用, 满了就刷到网络层.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Inspect the network callback and the session/SQL execution paths to understand where operator execution and RPC flushing currently occur; the issue proposes moving that work upward and reusing a buffer, but acceptance criteria and performance targets need clarification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend, databases
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100