ocaml / ocaml/ocamlbuild

MPR#6627: ocamlbuild adds read permissions on _build/*.ml files even if the original file didn’t have them

Open
#151 0 comments 0 reactions 1 assignee View on GitHub

@gasche is already working on this.

Since Feb 24, 2017.

bug
Dominant language
OCaml
Stars
133
Forks
87
No merged PRs in 30d

Description

PR transferred from https://caml.inria.fr/mantis/view.php?id=6627
[original reporter: @bfontaine]

When you create a .ml file with no read permissions for group/others, by e.g. runnning chmod go-r toto.ml, then run ocamlbuild toto.native, the file is copied into _build/ but its permissions are changed, and the read permission is back for everyone.

So anyone with access on the current directory can read _build/toto.ml even if they can’t read toto.ml (except for its owner).

  1. mkdir test && cd test
  2. touch toto.ml
  3. chmod go-r toto.ml
  4. ocamlbuild toto.native
  5. check the access permissions on _build/toto.ml

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.