Don't allow package names that aren't valid opam package names
Open
Nobody has claimed this yet.
enhancement
package management
- Dominant language
- OCaml
- Stars
- 1.9k
- Forks
- 500
- Avg merge
- 15h 21m
- Merged PRs (30d)
- 277
Description
Dune's Package_name.t type can represent names which are invalid for opam packgaes (e.g. names containing a '.'). We should prevent such Package_name.ts from being constructed so that all dune packages are are also valid opam packages.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the definition of Dune's Package_name.t and every constructor or parser that creates it. Inspect existing validation and tests for package names, then add coverage for invalid opam names such as names containing a dot. Done means invalid names cannot be constructed as Package_name.t values and relevant tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100