Disallow defining ppx_rewriters and ppx_derivers without omp or ppxlib drivers
Open
Nobody has claimed this yet.
preprocessing
- Dominant language
- OCaml
- Stars
- 1.9k
- Forks
- 500
- Avg merge
- 15h 21m
- Merged PRs (30d)
- 277
Description
Currently, such a ppx rewriter can be defined but it will not be usable. Attempting to use such a rewriter will give an opaque error about missing drivers. Instead, we should really just error out when we attempt to setup the build rules for such a faulty rewriter.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the build-rule setup for ppx_rewriters and ppx_derivers, then reproduce the configuration without an omp or ppxlib driver to inspect the current missing-driver error. Trace the existing validation path and make the setup fail clearly for this faulty definition; done means the invalid rewriter cannot proceed to an unusable build.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100