dune build accepts trailing slashes
Open
Nobody has claimed this yet.
build
cli
enhancement
- Dominant language
- OCaml
- Stars
- 1.9k
- Forks
- 500
- Avg merge
- 15h 21m
- Merged PRs (30d)
- 277
Description
dune build abc/ is accepted and interpreted as dune build abc even if abc is a file. This also applies to abc/// or @install///.
I think this is due to Path.of_string interpreting this as just abc.
Not sure at what point it should be fixed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the behavior with dune build abc/, abc///, and @install///, including the case where abc is a file. Start by tracing how Path.of_string handles trailing slashes and how the build command interprets the resulting path; done means these inputs no longer silently behave like their slash-free forms, with regression coverage for the reported cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- build-system, cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100