ocaml / ocaml/dune

dune-build-info reports wrong library version in vendored dir

Open
#8,025 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs-investigation vendoring
Dominant language
OCaml
Stars
1.9k
Forks
500
Avg merge
15h 21m
Merged PRs (30d)
277

Description

This was observed in https://github.com/mirage/mirage/issues/1438

Expected Behavior

ocplib-endian's version is reported as 1.2, or unknown.

Actual Behavior

ocplib-endian's version is reported to be the short git hash of the git repository in CWD, unrelated to ocplib-endian.

Additional information

It is unclear to me what a version of a library is as understood by dune-build-info. It also doesn't report the version of the compiler.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the dune-build-info entry point and tracing how it determines ocplib-endian's version when the library is vendored. Clarify the intended meaning of a library version, then verify that the reported value is no longer taken from the unrelated git repository in CWD and determine whether compiler-version reporting belongs in the same change.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
build-system
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.