Exit with code 0 when using —auto-promote
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 1.9k
- Forks
- 500
- Avg merge
- 15h 21m
- Merged PRs (30d)
- 277
Description
Running jbuilder build @settests --auto-promote where it is expected to promote a revised test/jbuild.inc file, but one ends up having to do sh -c "jbuilder build @settests --auto-promote || true" in, say, an opam file in order to skip the error.
It would be great if Dune returned exit code 0 when —auto-promote has been specified (assuming a fixed point in the build has been reached)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with jbuilder build @settests --auto-promote and the revised test/jbuild.inc described in the report. Trace how auto-promotion reaches a fixed point and how the command chooses its exit status; done means the command returns 0 after the expected promotion without requiring || true.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- build-system, cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100