ocaml / ocaml/dune

dirs should complain about non-immediate subdirectories

Open
#7,644 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

build enhancement
Dominant language
OCaml
Stars
1.9k
Forks
500
Avg merge
15h 21m
Merged PRs (30d)
277

Description

As attempted in https://github.com/ocaml/dune/pull/6640/files, Dune should complain when the user writes:

(dirs A/B)

and perhaps even suggest

(subdir A (dirs B))

instead.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the attempted changes in PR #6640 and trace how the (dirs A/B) form is handled. Confirm the desired behavior for non-immediate subdirectories, including whether to suggest (subdir A (dirs B)), and add coverage showing that the invalid form produces a complaint.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.