ocaml / ocaml/dune

Folders excluded from `dirs` are visited when calling `dune build @my_alias`

Open
#7,170 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
OCaml
Stars
1.9k
Forks
500
Avg merge
15h 21m
Merged PRs (30d)
277

Description

While running strace on some Dune builds, I noticed that some folders in the sources that are excluded from workspace —through dirs— are still visited, as stat is called from them. I will open a PR with a repro.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported behavior with a workspace using dirs exclusions, then run dune build @my_alias under strace as described. Done means excluded folders are no longer visited or stat'ed during the build; the issue does not mention specific files or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.