ocaml / ocaml/dune

Test suite is broken when CLICOLOR_FORCE=1

Open
#6,607 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

test-suite
Dominant language
OCaml
Stars
1.9k
Forks
500
Avg merge
15h 17m
Merged PRs (30d)
287

Description

When this environment variable is set, stderr and stdout are assumed to understand colors and so color codes are used. As a consequence, things like expect tests are outputting different strings depending on the environment variable. We want the results of these tests to be independent from the value of this environment variable.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the expect tests and the code that handles CLICOLOR_FORCE and colorized stdout or stderr. Run the affected test suite with CLICOLOR_FORCE=1 and without it; done means the expect test results are identical in both environments.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
build-system, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.