ocaml / ocaml/dune

env stanza should support variables `%{...}`

Open
#5,697 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

config
Dominant language
OCaml
Stars
1.9k
Forks
500
Avg merge
15h 21m
Merged PRs (30d)
277

Description

It is quite surprising to me that these are not supported today:

File "test-suite/test_suite_rules.sexp", line 21631, characters 27-42:
21631 |  (env (_ (env-vars (COQLIB %{project_root}))) (_ (binaries coqdoc))))
                                   ^^^^^^^^^^^^^^^
Error: Atom or quoted string expected
dune --version
3.1.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Use the example in test-suite/test_suite_rules.sexp, around line 21631, as the starting reproduction. Read how the env stanza parses COQLIB and %{project_root}, then verify that the variable form is accepted without the reported error. Done means the example works with dune and coverage protects support for variables in env stanzas.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
build-system
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.