ocaml / ocaml/dune

MDX stanza not causing dependencies to be built

Open
#4,971 1 comment 0 reactions 1 assignee View on GitHub

@voodoos is already working on this.

Since Oct 8, 2021.

mdx
Dominant language
OCaml
Stars
1.9k
Forks
500
Avg merge
15h 21m
Merged PRs (30d)
277

Description

Expected Behavior

When (using mdx 0.1) the files listed in the mdx stanza should be checked for existance and if they can't be generated an error should be raised.

Actual Behavior

The mdx stanza ignores all missing files and doesn't try to build or execute them.

Reproduction

  • PR with a reproducing test: #4973, otherwise:
  1. Clone https://github.com/Leonidas-from-XIV/mdx-rule-test
  2. dune runtest
  3. Test succeed, despite the test files missing

Specifications

  • Version of dune (output of dune --version): 2.9.1
  • Version of ocaml (output of ocamlc --version)
  • Operating system (distribution and version): Fedora Linux 34

Additional information

  • Link to gist with verbose output (run dune with the --verbose flag):

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.