Issues with --action-stdxxx-on-success
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 1.9k
- Forks
- 500
- Avg merge
- 15h 21m
- Merged PRs (30d)
- 277
Description
The current implementation of this option has a couple of problem. It operates at the level of a single (run ...) rather than at the level of whole actions. As a result:
- it has no effect on builtin actions such as
(echo ...) - the behaviour is somewhat unintuitive for actions with multiple
(run ...)
The motivation for the current behaviour was to get something up and running quickly that was enough for Jane Street use case where this option is needed now. However, we should change it to operate at the level of whole actions to fix this issues. See also #4435.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the implementation and entry point for --action-stdxxx-on-success, then read the related discussion in #4435. Trace how the option currently handles individual (run ...) forms versus whole actions. Done means builtin actions are affected and actions containing multiple (run ...) forms have consistent whole-action behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100