ocaml / ocaml/dune

Flush output buffers on SIGTERM

Open
#3,882 12 comments 0 reactions 2 assignees View on GitHub

@bximbo is already working on this.

Since Mar 25, 2025.

good first issue
Dominant language
OCaml
Stars
1.9k
Forks
500
Avg merge
15h 21m
Merged PRs (30d)
277

Description

We're currently using dune runtest in OCaml-CI as the standard way of running tests for a package. If some of the tests for a package get stuck in a deadlock, the CI job will kill the process after 60 minutes. Unfortunately, this means that the logs of the stalled test run are lost.

We could switch to using dune runtest --no-buffer in the CI, but this creates less readable (interleaved) test output. One possible alternative would be for Dune to flush its output buffers before responding to SIGTERM (probably keeping the old behaviour for SIGKILL). What do you think?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.