ocaml / ocaml/dune

%{env:FOO=<val>} does not accept spaces in <val>

Open
#3,755 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
OCaml
Stars
1.9k
Forks
500
Avg merge
15h 21m
Merged PRs (30d)
277

Description

(rule (alias foo) (action (echo "%{env:FOO=foo bar}")))

gives

File "dune", line 1, characters 35-36:
1 | (rule (alias foo) (action (echo "%{env:FOO=foo bar}")))
                                       ^
Error: This character is not allowed inside %{...} forms

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the minimal dune rule in the report and inspect the parser for %{env:...} forms. Trace why the space in the default value is rejected, then verify that the same rule parses successfully with a value containing spaces and add regression coverage where the parser tests live.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.